Skip to content

fix: PlotDummy item color #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brenocq merged 2 commits into from
May 10, 2026
Merged

fix: PlotDummy item color #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf6086a
chore: bump version to v0.5 WIP
brenocq May 10, 2026
ae3c0c1
fix: pick first non-auto color in PlotDummy
brenocq May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion implot3d.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: MIT
// SPDX-FileCopyrightText: 2024-2026 Breno Cunha Queiroz

// ImPlot3D v0.4
// ImPlot3D v0.5 WIP

// Acknowledgments:
// ImPlot3D is heavily inspired by ImPlot
Expand Down
6 changes: 3 additions & 3 deletions implot3d.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: MIT
// SPDX-FileCopyrightText: 2024-2026 Breno Cunha Queiroz

// ImPlot3D v0.4
// ImPlot3D v0.5 WIP

// Acknowledgments:
// ImPlot3D is heavily inspired by ImPlot
Expand Down Expand Up @@ -45,8 +45,8 @@
#define IMPLOT3D_API
#endif

#define IMPLOT3D_VERSION "0.4" // ImPlot3D version
#define IMPLOT3D_VERSION_NUM 401 // Integer encoded version
#define IMPLOT3D_VERSION "0.5 WIP" // ImPlot3D version
#define IMPLOT3D_VERSION_NUM 500 // Integer encoded version
#define IMPLOT3D_AUTO -1 // Deduce variable automatically
#define IMPLOT3D_AUTO_COL ImVec4(0, 0, 0, -1) // Deduce color automatically
#define IMPLOT3D_TMP template <typename T> IMPLOT3D_API
Expand Down
2 changes: 1 addition & 1 deletion implot3d_demo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: MIT
// SPDX-FileCopyrightText: 2024-2026 Breno Cunha Queiroz

// ImPlot3D v0.4
// ImPlot3D v0.5 WIP

// Acknowledgments:
// ImPlot3D is heavily inspired by ImPlot
Expand Down
2 changes: 1 addition & 1 deletion implot3d_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: MIT
// SPDX-FileCopyrightText: 2024-2026 Breno Cunha Queiroz

// ImPlot3D v0.4
// ImPlot3D v0.5 WIP

// Acknowledgments:
// ImPlot3D is heavily inspired by ImPlot
Expand Down
12 changes: 10 additions & 2 deletions implot3d_items.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: MIT
// SPDX-FileCopyrightText: 2024-2026 Breno Cunha Queiroz

// ImPlot3D v0.4
// ImPlot3D v0.5 WIP

// Acknowledgments:
// ImPlot3D is heavily inspired by ImPlot
Expand Down Expand Up @@ -1634,7 +1634,15 @@ void PlotText(const char* text, double x, double y, double z, double angle, cons
}

void PlotDummy(const char* label_id, const ImPlot3DSpec& spec) {
if (BeginItem(label_id, spec, spec.LineColor, spec.Marker))
// Pick the first non-auto color from the spec to override the legend icon color
ImVec4 item_col = spec.LineColor;
if (IsColorAuto(item_col))
item_col = spec.FillColor;
if (IsColorAuto(item_col))
item_col = spec.MarkerLineColor;
if (IsColorAuto(item_col))
item_col = spec.MarkerFillColor;
if (BeginItem(label_id, spec, item_col, spec.Marker))
EndItem();
}

Expand Down
2 changes: 1 addition & 1 deletion implot3d_meshes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: MIT
// SPDX-FileCopyrightText: 2024-2026 Breno Cunha Queiroz

// ImPlot3D v0.4
// ImPlot3D v0.5 WIP

// Acknowledgments:
// ImPlot3D is heavily inspired by ImPlot
Expand Down
Loading