Pin platform and Arduino versions

[HeMan]

Code fails to compile on newer versions of Arduino and platform

[learn-more]

I would suggest to fix the issues that occur instead of hiding them,
this will bite us later.

[HeMan]

I would suggest to fix the issues that occur instead of hiding them,
this will bite us later.

Depending on if the dependencies support Arduino 3.x it could become a somewhat bigger project to fix it. There have also been some controversy wrt Platformio and Arduino 3, https://www.cnx-software.com/2024/06/01/espressif-releases-arduino-esp32-core-3-0-0-but-platformio-support-in-doubt/ ,that could be worth taking in consideration.

[flattermann]

Just a quick question, not meant to sound negative, but who actually needs this change?

Is it necessary if you have newer PlatformIO/Arduino libs installed?

Because apparently, if you install PlatformIO from scratch (like e.g. the github action does), it seems to work fine without restricting the version.

Also, please use platform version 6.9.0+ (that's the version that will be used if installed from scratch):

PLATFORM: Espressif 32 (6.9.0) > DOIT ESP32 DEVKIT V1

[lyricnz]

@HeMan can you describe how to reproduce the problem with "fails to compile"?

I just opened a fresh checkout of on a brand new machine, without PlatformIO installed. I installed PlatformIO, then let it do "all the things", which took a couple of minutes. I then copied firmware/config/config.h.template to config.h and clicked the "build" button in the project task, which looks like it worked.

Relevant? logs:

CONFIGURATION: https://docs.platformio.org/page/boards/espressif32/esp32doit-devkit-v1.html
PLATFORM: Espressif 32 (6.9.0) > DOIT ESP32 DEVKIT V1
HARDWARE: ESP32 240MHz, 320KB RAM, 4MB Flash
DEBUG: Current (cmsis-dap) External (cmsis-dap, esp-bridge, esp-prog, iot-bus-jtag, jlink, minimodule, olimex-arm-usb-ocd, olimex-arm-usb-ocd-h, olimex-arm-usb-tiny-h, olimex-jtag-tiny, tumpa)
PACKAGES: 
 - framework-arduinoespressif32 @ 3.20017.241212+sha.dcc1105b 
 - tool-esptoolpy @ 1.40501.0 (4.5.1) 
 - toolchain-xtensa-esp32 @ 8.4.0+2021r2-patch5

This is an Apple M3 Pro if that matters...?

[HeMan]

I did some more testing, and the problem only arises when you have done other Platform.io projects that uses Arduino 3.x, so it's a really small group that gets bitten by this. However, having pinned versions is nice to have, since it ensures that every build uses the same Arduino versions.
I'll update the PR to use the latest platform version.