Skip to content

Conversation

@nconner-06
Copy link

As posted on Discord, I've tried generating a pull request for the additional features I have developed

  • Changed the API used for TZ to not require an API key
  • Added support for multiple TZ - up to 5 in total
  • Added a new clock type MORPH
  • Added support for a Second Weather location
  • Added support for OpenWeatherMap API
  • Added support for Lat/Long locations
  • Added addition functionality to the web interface to support these new functionalities
  • Added minute support to the DIM function
  • Changed the Host name of the Orb to "ESP32-Orb"
  • And a few other minor changes.

@nconner-06
Copy link
Author

Sorry, I just noticed there was a change to the config.h.template file.. I've uploaded a new copy to my branch.
Do I need to do anything to include it in this pull request or is it automatic?

@dreed47
Copy link
Contributor

dreed47 commented Mar 2, 2025

Your PR is greatly appreciated but you'll have a much better chance of getting these changes merged if you break this up into smaller PRs. Just a few suggestions. Try to keep one PR focused on only one feature or change. Also you have many many commits that don't have meaningful comments. It's best to have as few commits as possible and use comments that are meaning and relavant to tell code reviewers what, why, how you are changing this code. The other issue you'll have with too many changes in one PR is that your PR will quickly develop code conflict as it touches too many parts of the app. These code conflicts have to be resolved before you PR can be merged. Think about the PRs from the standpoint of the code reviewers. If the PRs are smaller and focused on only one change people are more likey to take the time to read the code and give you meaning feedback and help you get your changes into the code base. I'm interested in some of these changes myself particularly the OpenWeatherMap stuff

@nconner-06
Copy link
Author

Hi dreed47
Thanks for your feedback.. I must admit I got a little carried away developing changes and didn't stop to check point them into smaller sections.
If you want to 'leverage' any of my ideas, feel free... I'm more a 'problem solver' than a developer, so am good at providing 'snippets' of code which other people can combine to provide a fully working program.
But I'll try and split out a few of my changes into smaller PRs, like the TZ api change, etc all based on the DEV branch
Thanks again
Neil

@dreed47
Copy link
Contributor

dreed47 commented Mar 2, 2025

Hi dreed47 Thanks for your feedback.. I must admit I got a little carried away developing changes and didn't stop to check point them into smaller sections. If you want to 'leverage' any of my ideas, feel free... I'm more a 'problem solver' than a developer, so am good at providing 'snippets' of code which other people can combine to provide a fully working program. But I'll try and split out a few of my changes into smaller PRs, like the TZ api change, etc all based on the DEV branch Thanks again Neil

I created a PR for setting the hostname #248

@nconner-06
Copy link
Author

I'm starting to split these changes into smaller PR, first one is
Update to changeFormat function in ClockWidget to remove unneeded key press #256

@flattermann flattermann added the DO NOT MERGE Work in progress not ready to be considered for merging label Mar 4, 2025
@flattermann
Copy link
Collaborator

Let's keep this PR for reference, but merge the individual PRs.

@nconner-06
Copy link
Author

I just created a PR for the TZ api change in this package:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Work in progress not ready to be considered for merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants