Dev weather - linked to issue #287 / #298 / #288 plus additional feed #289
Conversation
Pagination of stocks
…gination Don't rotate stock pages if there is only 1
…ter-markdown-fixes Feature/megalinter markdown fixes
…eToDraw() and isItTimeToUpdate() methods to Widget.cpp. Changed WeatherWidget to add timers in its constructor. Changed WidgetSet to only call update and draw if the timers are expired.
nconner-06
changed the title
|
This PR handles the following issues:
And includes a new feed from Pirate Weather |
…agement Consolidate Widget draw and update frequency management
Switch to new API provider for the timeZone information
flattermann
left a comment
flattermann
left a comment
There was a problem hiding this comment.
I would also comment out the WEATHER_* #defines in config.h.template so that the user can enable what he needs.
And move the default values to config.system.h (if #ifndef) because we might otherwise get compilation errors.
| #elif WEATHER_VISUALCROSSING_FEED | ||
| return new VisualCrossingFeed(WEATHER_VISUALCROSSING_API_KEY, weatherUnits); | ||
| #endif | ||
| switch (WEATHER_FEED) { |
There was a problem hiding this comment.
I'm not 100% sure, but I think a switch might cause some problems here, because it might compile/link the unnecessary feeds as well? Needs testing.
We could switch to #if WEATHER_FEED == VISUALCROSSING if necessary (but we need to #define VISUALCROSSING 0 because enum items can't be used by the preprocessor)
There was a problem hiding this comment.
Thanks for your feedback, I'll look at your comments.
Did you look at the weather feed .h file, each has a #ifndef section to define the variables, thus I don't know if we need it in config.system.h as well
There was a problem hiding this comment.
As the header files for all the feeds are included in WeatherWidget.cpp, it looks like all the feeds get compiled and linked - even if I change to a "#if" condition...
There was a problem hiding this comment.
Right. If the defaults are already set in the individual feed .h, we don't need them in config.system.h.
Maybe include the feeds conditionally as well?
There was a problem hiding this comment.
I tested both way - switch and ifdef (including ifdef on the fee.h files) and it appears that all feeds are included in the compile / ink.. not sure if I was doing any incorrect, if you know a way, then I'm open to suggestions.
6 participants
Move the variables for LAT and LOG to float for OpenWeathermap to floats