Improve parser error message for missing units in equations#1787
Open
has9sayed wants to merge 6 commits into
Open
Improve parser error message for missing units in equations#1787has9sayed wants to merge 6 commits into
has9sayed wants to merge 6 commits into
Conversation
A more explicit error message when a user forgets to specify the units in an equation. It intercepts the generic `Expected end of text` error from pyparsing and now suggests checking for an omitted unit or missing colon (:), improving the debugging experience for syntax errors.
Contributor
Author
|
Improve Equations parsing by replacing generic pyparsing errors and raw Python tracebacks with targeted diagnostics.
Output - @mstimberg Is this how we wanted? |
Member
|
Hi @has9sayed, thanks for the PR. I will need a bit more time to look into this in detail – at a cursory look this looks more complex/comprehensive than what I had in mind, but maybe that's a good thing 😊 |
Contributor
Author
|
Improved diagnostics for missing unit separators in equations.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A more explicit error message when a user forgets to specify the units in an equation. It intercepts the generic
Expected end of texterror from pyparsing and now suggests checking for an omitted unit or missing colon (:), improving the debugging experience for syntax errors.