Refactor WASMStandaloneDevice Build: Drop distutils, add native emcc prefs#20
Merged
Conversation
Contributor
Author
|
Hi @mstimberg, is there anything else you’d like me to change in this PR? |
Member
|
Hi @PalashChitnavis Sorry, I wasn't much available the last days. Your changes look good, but here are a few suggestions for things to change/add:
|
mstimberg
approved these changes
Jul 18, 2025
mstimberg
left a comment
Member
There was a problem hiding this comment.
LGTM, we can do the README changes later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19
This patch makes the WASM backend talk straight to emcc instead of first trying to use GCC or MSVC. It adds two new preference lists where you can set your own emcc compile- and link-flags. The build code now writes the right -I, -L, and -l flags itself, so no more post-hacking or flag cleanup is needed. Result: you only need Python and the Emscripten SDK—no Visual Studio or system compiler required.