fix(pg-pool): don't throw on readonly .message e.g. ErrorEvent, preserve original exception #3374

andyjy · 2025-02-10T12:54:36Z

…row on readonly .message e.g. ErrorEvent Fixes brianc#3373

andyjy · 2025-02-10T12:57:19Z

packages/pg-pool/index.js

@@ -244,7 +244,7 @@ class Pool extends EventEmitter {
        // remove the dead client from our list of clients
        this._clients = this._clients.filter((c) => c !== client)
        if (timeoutHit) {
-          err.message = 'Connection terminated due to connection timeout'
+          err = new Error('Connection terminated due to connection timeout', { cause: err } )


Node.js support for Error.cause added in 16.9.0, prior versions will silently ignore - has the effect of losing the stack trace of the original exception under these older Node.js versions

brianc · 2025-02-10T22:27:34Z

Thanks! I'll push a new patch version out tomorrow morning. 😄

fix(pg-pool): preserve original error on connection timeout, don't th…

33e8249

…row on readonly .message e.g. ErrorEvent Fixes brianc#3373

andyjy commented Feb 10, 2025

View reviewed changes

Fix lint

b6e8526

brianc merged commit 95bec69 into brianc:master Feb 10, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(pg-pool): don't throw on readonly .message e.g. ErrorEvent, preserve original exception #3374

fix(pg-pool): don't throw on readonly .message e.g. ErrorEvent, preserve original exception #3374

andyjy commented Feb 10, 2025

andyjy Feb 10, 2025

brianc commented Feb 10, 2025

fix(pg-pool): don't throw on readonly .message e.g. ErrorEvent, preserve original exception #3374

fix(pg-pool): don't throw on readonly .message e.g. ErrorEvent, preserve original exception #3374

Conversation

andyjy commented Feb 10, 2025

andyjy Feb 10, 2025

Choose a reason for hiding this comment

brianc commented Feb 10, 2025