Open
Conversation
Fix number of arguments
bump to version 0.2.25
Author
|
Anybody alive here?.. |
Collaborator
|
Can you use a newer version of the gem to that supports current versions of Ruby? The mysql2 0.2 series is rather out of date. |
Author
Thank you for your reply! I support Rails 2.3 application. We try to switch to Rails 2.3 LTS + Ruby 2.5, and it forces us to use mysql2. And as I understand, 0.2.x is the only branch compatible with ActiveRecord from Rails 2.3.. |
Collaborator
|
What is Rails 2.3 LTS? |
Author
|
Author
|
Here is their recommendation to use mysql2. https://makandracards.com/railslts/47192-ruby-2-5-support-for-rails-2-3-lts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mysql2 0.2.24 does not compile in ruby 2.5 due to extra check this ruby performs on rb_funcall.
In particular, file result.c had a bug - wrong number (6) of arguments on line 300.
I ask to merge this changeset in master repository and also ask to build and publish gem version 0.2.25.