Tuning shop: perf optimizations for result fetching#1422
Draft
jeremy wants to merge 11 commits intobrianmario:masterfrom
Draft
Tuning shop: perf optimizations for result fetching#1422jeremy wants to merge 11 commits intobrianmario:masterfrom
jeremy wants to merge 11 commits intobrianmario:masterfrom
Conversation
When using as: :array mode, field names are allocated but never used. Skip rb_mysql_result_fetch_field() -> profit.
In Array mode, field names are not used during iteration. Lazy-generate, eliminating 1 Array + N field name Strings per query.
* Eliminate repeated rb_enc_find_index lookups by caching db charset -> Ruby encoding mappings. * ~4.6% faster on benchmark query with 1000 string fields.
When db and app are all UTF-8 (for example) skip costly charset -> encoding handling with `force_encoding: "utf-8"`. Benchmark query with 1000 string fields * `cast: true`: 53% faster * `cast: false`: 17% faster
Optimistically 20+% faster due to casting fields likely to be accessed, like integer, while leaving datetime, decimal, etc for lazy attrs.
Contributor
Author
|
This is an omnibus branch will all perf tunings. I'll split these out into distinct PRs for individual consideration. |
Collaborator
|
Looking good!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A series of profiling-guided optimizations to reduce object allocation and speed up hot paths in result processing, inspired by Trilogy's approach:
Allocation reductions:
Fast-path optimizations:
Partial casting:
Benchmarks: 17-53% faster depending on query shape and options.