Remove 1.8.7,ree compatibility shim - #908
Merged
Merged
Conversation
sodabrew
requested changes
Nov 25, 2017
| * only -0x8000000000000000 is safe if `len == 8 && nlz_bits == 0` | ||
| */ | ||
| !rb_absint_singlebit_p(bignum) | ||
| #elif defined(HAVE_RB_BIG_CMP) |
Collaborator
There was a problem hiding this comment.
This case should still be needed for Ruby 1.9 and 2.0.
Contributor
Author
There was a problem hiding this comment.
Oh, I misread that elif as ifdef. Derp.
Contributor
Author
There was a problem hiding this comment.
Alright, this is fixed up and green now.
sodabrew
approved these changes
Nov 26, 2017
jeremy
added a commit
to jeremy/mysql2
that referenced
this pull request
Nov 29, 2017
* master: (56 commits) Remove leftover ifdef HAVE_RB_BIG_CMP Minor whitespace/variable rewording Prefix the methods in client.c with rb_mysql_ Prefix the methods in statement.c with rb_mysql_ Remove more 1.8.7, REE compatibility shims (brianmario#908) Style/SignalException Style/PercentLiteralDelimiters Style/NumericPredicate Style/MutableConstant Style/IfInsideElse Style/HashSyntax Style/GuardClause Style/Encoding Style/BlockDelimiters Style/Alias Performance/TimesMap Performance/RedundantMerge Performance/HashEachMethods Naming/HeredocDelimiterCase Lint/UnifiedInteger ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sodabrew looks like I missed one (that was added after the original PR opened).