Add AEAD_AES_128_CCM support #1501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I agree to license my contributions to each file under the terms given at the top of each file I changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCM is defined generically with varying Tag and Nonce lengths. This implementation constrains:
per RFC 5116.
The end goal is of this PR is to get CCM modes into Rustls:
rustls/rustls#1034
Adding CCM with 16-byte tags fit perfectly into how ring currently defines other AEADs. We would need to modify the Tag abstraction a bit to support AES_128_CCM_8 which is just a truncation of the 16-byte tag.