aes-gcm: Make use of the optimized aarch64 implementation #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkrasnov
force-pushed
the
vlad/gcm
branch
2 times, most recently
from
a2b6569 to
94ddede
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
==========================================
+ Coverage 96.22% 96.23% +0.01%
==========================================
Files 135 135
Lines 20550 20632 +82
Branches 226 226
==========================================
+ Hits 19774 19855 +81
- Misses 742 743 +1
Partials 34 34 ☔ View full report in Codecov by Sentry. |
briansmith
reviewed
Jan 26, 2024
Currently ring bundles an interleaved AES-GCM implementation for aarch64, but does not make use of it, instead calling AES-CTR + GHASH in succession. This change makes use of the bundled implementation, resulting in speedups of 45% for AES-128-GCM 1350B and 55% for AES-128-GCM 8192B on an Apple M1 CPU.
|
I have now tested this on Windows 11 aarch64-pc-windows-msvc and verified that the implementation is selected and that the tests pass. |
|
And how the performance on that platform? |
I didn't run the benchmarks because I actually ran the test in Parallels on an M1 Mac. The only ARM64 Windows hardware I have is an original Surface Pro X (SQ1) tablet which isn't very relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ring bundles an interleaved AES-GCM implementation for aarch64, but does not make use of it, instead calling AES-CTR + GHASH in succession.
This change makes use of the bundled implementation, resulting in speedups of 45% for AES-128-GCM and 55% for AES-256-GCM on Apple M1 CPU.