cpu::intel: Do CPU feature detection in Rust. #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2439 +/- ##
==========================================
- Coverage 96.56% 96.21% -0.35%
==========================================
Files 182 181 -1
Lines 19951 19898 -53
Branches 540 527 -13
==========================================
- Hits 19265 19145 -120
- Misses 567 638 +71
+ Partials 119 115 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
briansmith
force-pushed
the
b/fxsr-3
branch
3 times, most recently
from
b5065dd to
272682e
Compare
briansmith
commented
Mar 4, 2025
| extended_features_ecx = 0; | ||
| extended_features_ebx = 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
As codecov points out, and the comment notes, these lines are unreachable in unpatched versions of ring. (Some people do patch it in ways that make these lines reachable.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easiest to review this PR commit-by-commit.