0.17.12 #2448
Merged
0.17.12 #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-branch/0.17.12 #2448 +/- ##
==========================================================
- Coverage 96.62% 96.61% -0.01%
==========================================================
Files 176 176
Lines 21637 21637
Branches 533 533
==========================================================
- Hits 20906 20904 -2
Misses 618 618
- Partials 113 115 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Note that the target branch for this is the newly-created release-branch/0.17.12 branch that is based on release-branch/0.17.11 which is what the 0.17.11 release was done from. |
|
On the main branch, there were changes to increase MSRV and to potentially increase the binutils version required, so I decided to do this off a branch. Now the changes scheduled for 0.17.12 will be 0.17.13. |
The problem occurs: * release mode with `RUSTFLAGS="-C overflow-checks"` * release mode with `overflow-checks = true` in the Cargo.toml profile. * debug mode. Thanks to Mike (GitHub user MikeRomaniuk).
briansmith
force-pushed
the
b/0.17.12
branch
3 times, most recently
from
b8487a2 to
641c1c7
Compare
|
The clippy failure is something we fixed after 0.17.11 and it's benign. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.