have old binutils support on AVX10 as well and improve it #2476
+100
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I will review this probably next week. In the meantime, could you replace the "AVX 1.0" references in the PR title/summary and in the patch itself (if any) with "AVX10"? Also, could you do a diff between aes-gcm-avx2-x86_64.pl an aes-gcm-avx10-x86_64.pl to ensure that the perl code you added to both matches as closely as possible (no superfluous differences)? |
|
Also, thank you! |
I copy pasted it, will do another diff |
Currently there are no ymm/zmm in the avx10 code, but there will be. I tested that when you fill out the map correctly, this code will work for AVX-512 as well, being able to result in the same objdump if you use make-avx-map-for-old-binutils to generate an asmMap. Made the perl code less sensitive to whitespace differences, I still think it's pretty understandable. This currently does not change anything, not even the .S output.
|
updated, couldn't find any more reference to AVX 1.0. The diff between the 2 perl files is exactly what it should be. |
briansmith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are no ymm/zmm in the AVX10 code, but there will be.
I tested that when you fill out the map correctly, this code will work for AVX-512 as well, being able to run on AL2 and result in the same objdump if you use make-avx-map-for-old-binutils to generate an asmMap.
Made the perl code less sensitive to whitespace differences, I still think it's pretty understandable.
This currently does not change anything, not even the .S output [and therefore does not change the .o output or its objdump].