CI: Don't build/run doctests in test-features jobs. #2532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
The doctests are built/run in separate test-doc jobs so we don't need to run them in test-features. This will speed up CI slightly. This will also work around some incompatibility introduced in recent Rust 1.87 and/or Nightly releases where linking the doctests fails when cross-compiling. (Rust recently started building doctests when cross-compiling where previously it ignored them during cross- compilation.)
briansmith
force-pushed
the
b/no-doctest-in-test-features
branch
from
40e9b72 to
5f3a038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doctests are built/run in separate test-doc jobs so we don't need to run them in test-features.
This will speed up CI slightly.
This will also work around some incompatibility introduced in recent Rust 1.87 and/or Nightly releases where linking the doctests fails when cross-compiling. (Rust recently started building doctests when cross-compiling where previously it ignored them during cross- compilation.)