Add getQuarter() to LocalDate fixes #117 #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscheit
commented
Jul 22, 2025
BenMorel
reviewed
Aug 17, 2025
Member
|
@pscheit Sorry for the late feedback! This looks good already, tests are solid. Let's move forward! |
Contributor
Author
|
Nice, thanks for the review, i am on it |
Contributor
Author
|
You want me to rebase + squash that? |
Contributor
Author
|
@BenMorel added your feedback, btw :) |
BenMorel
reviewed
Aug 21, 2025
Member
|
@pscheit Thank you, just a couple changes left to better align with the rest of the codebase, and we should be good to go! 👍 |
Contributor
Author
|
@BenMorel okay, done : ) |
Member
|
Thank you, @pscheit! |
Member
|
Released in version 0.7.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation suggestion for: #117
I was very unsure about the actual implementation (lol). Would you add ceilXyz() to class Math?
I was unsure about adding more bells and whistles (especially to the Quarter enum?).
Figured a serialized value of integer might be okay?
Let me know whats missing.