Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): handle connected_node tuple in CustomJSONEncoder for json report (#7062) #7063

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joeyhage
Copy link

@joeyhage joeyhage commented Mar 20, 2025

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

A change was made on Mar 5 to graph checks and how connected nodes were handled. This change inadvertently broke JSON output when the compact flag is off (default). This pull request adds a test case and fixes JSON output for graph scans of cloudformation.

Fixes #7062

Checklist:

  • I have performed a self-review of my own code
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

TopicDetails
Test Updates Adds a new test case for tuple key encoding in the CustomJSONEncoder
Modified files (1)
  • tests/common/utils/test_json_utils.py
Latest Contributors(2)
UserCommitDate
rotemavnifix-general-Support-en...January 16, 2023
gruebelconsolidate-custom-jso...November 30, 2021
JSON Encoder Fix Modifies the CustomJSONEncoder to handle tuple keys by joining them with commas
Modified files (1)
  • checkov/common/util/json_utils.py
Latest Contributors(2)
UserCommitDate
arielkrufeat-sast-Add-sast-met...December 31, 2023
gruebelchore-replace-deepcopy...May 24, 2023
This pull request is reviewed by Baz. Join @joeyhage and the rest of your team on (Baz).

@joeyhage joeyhage marked this pull request as ready for review March 20, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json: output failure occurs for cloudformation results with connected node
1 participant