fix(general): Support list definition in external custom policies#7437
Open
inbalavital wants to merge 1 commit intomainfrom
Open
fix(general): Support list definition in external custom policies#7437inbalavital wants to merge 1 commit intomainfrom
inbalavital wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Problem
Loading external custom policies with a list-type definition block crashes with AttributeError: 'list' object has no attribute 'get' in get_complex_operator() in checkov/common/checks_infra/checks_parser.py:359
The validator at validate_check_config() checkov/common/checks_infra/checks_parser.py:193
explicitly accepts both list and dict definitions, but parse_raw_check() common/checks_infra/checks_parser.py:202 passed the list directly to _parse_raw_check() common/checks_infra/checks_parser.py:234, which assumes a dict.
Fix
In parse_raw_check() common/checks_infra/checks_parser.py:205, wrap list-type definitions as an implicit AND: [cond1, cond2] → {"and": [cond1, cond2]}. This is consistent with how the Bridgecrew platform represents compound policies.
Checklist: