fix(bicep): support multi-line function calls#7457
Open
safejulian wants to merge 3 commits intobridgecrewio:mainfrom
Open
fix(bicep): support multi-line function calls#7457safejulian wants to merge 3 commits intobridgecrewio:mainfrom
safejulian wants to merge 3 commits intobridgecrewio:mainfrom
Conversation
This commit updates the Pycep library to improve Bicep parsing, with tests to demonstrate that parsing is successful for the issue raised in issue 7316. Tested on some real world Bicep code that has multi-line functions, and Checkov reports fewer parsing errors.
Contributor
|
Hi safejulian, Thank you for your contribution! We are currently reviewing your changes, specifically as they relate to upgrading Checkov to support Python 3.10 and above. We appreciate your patience and your help in improving the project! |
Author
Hey @OfekShimko Thanks for letting me know. I understand the need for extra diligence on the runtime changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
This PR fixes issue 7316; where a request was made for support of multiline function calls. This is an issue for an organisation that I know.
The PR has a test to demonstrate the issue, and updates the
pycep-parserlibrary version to improve Bicep parsing. The test now passes (as do all others)Tested on some real world Bicep code that has multi-line functions, and my local Checkov reported fewer parsing errors.
pycep-parsee0.7.0 doesn't support Python 3.9 - presumably as 3.9 is unsupported now. So I had to bump the Python version.Fixes #7316
Checklist:
(no runtime code changed, no documentation needed for minor enhancement)