fix(terraform): evaluate for expressions in module for_each#7505
Open
pszypowicz wants to merge 1 commit intobridgecrewio:mainfrom
Open
fix(terraform): evaluate for expressions in module for_each#7505pszypowicz wants to merge 1 commit intobridgecrewio:mainfrom
pszypowicz wants to merge 1 commit intobridgecrewio:mainfrom
Conversation
…ewio#7503) When a module's for_each uses a for expression with a simple identity mapping like { for v in var.items : v => v }, the expression evaluator assumed iterable items are always dicts and tried obj[k_expression], which fails with TypeError on string items. Handle the case where the key expression is the loop variable itself by using the item directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7503
When a module's
for_eachuses aforexpression with a simple identity mapping (e.g.{ for v in var.items : v => v }),_handle_for_loop_in_dict()assumed iterable items are always dicts and triedobj[k_expression], which raisesTypeErroron string items. The module was silently skipped.for_eachTest plan
test_handle_for_loop_in_dict_with_simple_iterable--{for v in ['a', 'b'] : v => v}evaluates to{'a': 'a', 'b': 'b'}test_foreach_module_with_for_expression-- module withfor_each = { for v in var.items : v => v }expands tochild["a"]andchild["b"]tests/terraform/graph/variable_rendering/suite passes (207 passed, 0 failed)