Conversation
6bf8d0e to
bfcafea
Compare
bfcafea to
def8289
Compare
|
@ayushn21 The version info needs to live in the foundation gem because that can be loaded in standalone in other projects now (without pulling in any other gems from this repo). I suppose we could have a version defined in both gems and endeavor to keep them in sync, but my preference would be to figure out a better solution. |
|
Ahh I see, leave it with me, I'll have a think |
|
I'm not quite sure I understand why we need the version in the The only place the gem needs the version is in the gemspec right? That's only evaluated when we're releasing the gem or when bundling from a local path? In both those cases, I created a blank project and added Am I missing something here? Is there any reason the setup I've proposed in this PR won't work even if we pull in |
|
I think you broke my brain a little bit. 😅 You could very well be right. I'll have to come back to this when my head is more clear… |
|
Haha sure no rush! Thanks!
…On March 13, 2026, GitHub Notification ***@***.***> wrote:
jaredcwhite left a comment (bridgetownrb/bridgetown#1085)
<#1085 (comment)-
4056113840>
I think you broke my brain a little bit. 😅 You could very well be
right. I'll have to come back to this when my head is more clear…
—
Reply to this email directly, view it on GitHub
<#1085 (comment)-
4056113840>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/ABFSFB3EJFDDWS2YQ7BFWDT4QQUKXAVCNFSM6AAAAACWQMF67SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANJWGEYTGOBUGA>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'm not entirely sure why we moved our
version.rbfile tobridgetown-foundation... @jaredcwhite perhaps you might remember?Anyway, if I point
bridgetown-coreat a local path on my machine, I keep getting these annoying error in the console:Seems
version.rbfile is beingrequired multiple times from different places and hence causing these errors. I've feel that theversion.rbshould live in the top levelbridgetowngem since that's what glues everything together.I've moved it back there and these errors seem to be resolved (although I'm still not fully sure I understand why, perhaps I'm just too sleepy haha).
This is a 🐛 bug fix.
Summary
I know this isn't really an issue. It's a weird edge case when pointing a bridgetown gem to a local path, but even so I think it's a little thing we should fix just to be logically correct. Totally open to feedback on this though as I'm probably lacking some context around this setup.