This repository was archived by the owner on May 27, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 145
Populate the 'authors' table with unique commit authors. #386
Open
veenstra
wants to merge
7
commits into
brightcove-archive:master
Choose a base branch
from
veenstra:authors_table
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please don't pull this yet. These commits populate the db tables. But I need to add the code that maintains these tables when new commits are ingested. Otherwise, we will have to re-populate the tables. I will create a new commit and add it to this branch (which will add it to this pull request). |
…ngested. This also fills in the "author_id" field for new commits.
Contributor
Author
|
Okay, I believe this is ready to merge now. |
Contributor
Author
|
Wait, don't pull yet. I want to make a change to the migration that populates the author_id field in the commits table. |
Contributor
|
Stop playing with my ❤️ |
…over the db commits (instead of Grit).
Contributor
Author
|
Okay, now it's ready. pretty sure ... :-) |
Contributor
Author
|
Actually, one more change is coming... |
Contributor
Author
|
Okay, now it's ready. For sure. I'd bet a nickel on it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration script finds the unique commit authors from the "master" branch in all of the known repos and inserts them into the "authors" table if they do not already exist (which they shouldn't, but adding a check was easy and allows the script to be run safely more than once). It also finds matching entries in the "users" table (by email) and fills in the "user_id" field.