This repository was archived by the owner on May 27, 2025. It is now read-only.
support different email for signin#447
Open
kumm wants to merge 2 commits intobrightcove-archive:masterfrom
Open
support different email for signin#447kumm wants to merge 2 commits intobrightcove-archive:masterfrom
kumm wants to merge 2 commits intobrightcove-archive:masterfrom
Conversation
|
+1 |
|
Hi kumm, how can I use your modifications in barkeep? Thanks! |
Author
|
I have not changed the authentication method. It's oauth with google. So the login page is always the google's page. |
|
ok, thank you! |
|
I tried merging this on top of bb24f22 but I got Full stack trace https://gist.github.com/epeli/10867578 |
|
Update: It seems that I just forgot to run the migrations. Ok to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now barkeep thinks my gmail address for signin is the same to the email address in my commits. This is not the case.
I've introduced a new login field for signin, and made current email address editable.
Just the signin process changed slightly, everything works as before. Except you can configure your email address.
As before, all outgoing mail sent to this address, and the commits have to contain this address too.
A migration also included to fill the new login field to the current email, so existing users works after this change.
In general, this is another apporach to issue #426