fix: Stop polling on HTTP 400 errors in web data tools #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Web data tools were continuously polling and timing out when the API returned HTTP 400 errors (e.g., "Snapshot is empty"). This resulted in unnecessary API calls and long wait times before eventual timeout.
Solution
Added a check to immediately fail on HTTP 400 responses in the polling loop. Since 400 errors indicate client errors that won't resolve with retrying, we now throw the error immediately instead of continuing to poll.
Changes
if (e.response?.status === 400) throw e;
in the polling catch blockTesting
Verified that failed snapshots (returning "Snapshot is empty" with HTTP 400) now fail immediately instead of timing out after 600 attempts.