Fix CAS RegEx and add local xml.xsd #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Add required version attribute to ILCD_LifeCycleModelDataSet schema
chore: Update LICENSE and README files for pyeilcd package, add Chinese documentation
fix: Correct link to Chinese documentation in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following updates:
It fixes the CAS RegEx pattern in the XML schema file. The original pattern from the ILCD schemas incorrectly allowed only six digits in the first segment. The pattern has now been modified to allow 2 to 7 digits before the first hyphen, thereby enhancing the accuracy of CAS Number validation.
It adds a local copy of xml.xsd to improve batch processing performance. Previously, each validation attempt accessed http://www.w3.org/2001/xml.xsd, which could lead to network errors and validation failures due to the large volume of files being verified. By using a local copy, these issues are mitigated.