Allow quoted terms within a range expression#41
Open
maxtilford-sc wants to merge 1 commit intobripkens:masterfrom
Open
Allow quoted terms within a range expression#41maxtilford-sc wants to merge 1 commit intobripkens:masterfrom
maxtilford-sc wants to merge 1 commit intobripkens:masterfrom
Conversation
|
We also encountered this issue. Please merge this into master! |
bripkens
reviewed
Aug 17, 2022
| expect(results['left']['inclusive']).to.equal('right'); | ||
| }); | ||
|
|
||
| it('parses a quoted term in a range expression', () => { |
Owner
There was a problem hiding this comment.
Can you please also add a toString() test case? Thank you!
Author
There was a problem hiding this comment.
I don't have bandwidth at the moment.
@ddio Since you're interested perhaps you'd like to add a toString() test case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows terms within a range expression to be quoted.
This works in our other tools and a we have a bunch of queries we'd like to use this library on.
This seemed like the simplest fix, but happy to make changes if it's not correct.