Skip to content

Conversation

shoboske
Copy link

This fixes the issue reported in #149 by filtering out the PrivacyInfo.xcprivacy from the source file.

The issue in #149 causes the following error to be thrown when building with Xcode 15

    no rule to process file '/Users/runner/.pub-cache/hosted/pub.dev/in_app_review-2.0.10/ios/in_app_review/Sources/in_app_review/PrivacyInfo.xcprivacy' of type 'text.xml' for architecture 'arm64' (in target 'in_app_review' from project 'Pods')

This was because the PrivacyInfo.xcprivacy file was included as a source file

@shoboske shoboske changed the title Fix issue caused by PrivacyInfo.xcprivacy causing build to fail Fix issue caused by PrivacyInfo.xcprivacy causing build on Xcode to fail Mar 15, 2025
@shoboske
Copy link
Author

@britannio, could you please look at this, as it’s quite urgent.

@britannio
Copy link
Owner

Would it be easier to move the file to a /Resources folder instead of /Sources?

@shoboske
Copy link
Author

Would it be easier to move the file to a /Resources folder instead of /Sources?

@britannio, that's actually a good idea to move it to a different folder, I can do that, just consider that adding this filter ensures that only 'actual' source files are processed.

@shoboske
Copy link
Author

@britannio, I have moved it to the resources directory, can you please check it again?

Although, I am not certain of whether the Package.swift will need to change also

@arnoorani
Copy link

Has this issue been fixed? how can I fix this issue using in_app_review: ^2.0.10

@robport
Copy link

robport commented May 12, 2025

Any plans to merge this?

@shoboske
Copy link
Author

Has this issue been fixed? how can I fix this issue using in_app_review: ^2.0.10

This hasn't been fixed yet, still waiting on it to get merged

@robport
Copy link

robport commented May 12, 2025

Has this issue been fixed? how can I fix this issue using in_app_review: ^2.0.10

As a temporary fix, I forked this branch into my own account, and updated the pubspec.yaml;

in_app_review:
git:
url: [email protected]:your github id/in_app_review.git
ref: patch-2
path: in_app_review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants