-
Notifications
You must be signed in to change notification settings - Fork 4
Pepper 1251 playwright place an order in mercury #2412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rinchan20
wants to merge
37
commits into
develop
Choose a base branch
from
pepper-1251-playwright-place-an-order-in-mercury
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
66c1857
WIP
Rinchan20 77f02ad
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 36ba812
putting in method to get relevant ptps
Rinchan20 c9eb0d1
in sequencing order tab
Rinchan20 cc32002
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 414dacf
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 bfbfb5b
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 fb683a5
continuing with placing a clinical order
Rinchan20 5571344
beginnings of placing a mercury order also installed gcp pubsub library
Rinchan20 0bbe6cb
ran npm audit fix to fix some vulnerabilities
Rinchan20 a106f63
placed mercury order and checking for the resulting order in Clinical…
Rinchan20 e03e40f
small fixes
Rinchan20 b8c5a2c
took out topic line
Rinchan20 36b7572
test for putting in mercury order for lost to followup pediatric ptp …
Rinchan20 103ac23
inputting test case for a lost to followup ptp whose residence is in …
Rinchan20 28c11bb
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 667f73c
adding LMS to test
Rinchan20 feb2e22
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 6a6d495
making changes to allow LMS to be used
Rinchan20 89143da
slight changes
Rinchan20 b9b6a9b
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 81adeef
get rid of empty method
Rinchan20 b00e788
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 acce255
cleanup
Rinchan20 88f4a47
got rid of space
Rinchan20 31085ef
more cleanup
Rinchan20 560f169
connecting to mercury info in vault
Rinchan20 e2b5faf
implement feedback
Rinchan20 bc42eec
decreasing intervals for waiting for expectToPass
Rinchan20 20890c8
adding expectToPass since it seems it might need it on a circleci run
Rinchan20 d7af043
checking if timing works better for circleci since it passes locally
Rinchan20 52b6429
adding more logging to try to find where test is failing in circleci
Rinchan20 0d30582
description change
Rinchan20 cb7b72d
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 cf0b52b
attempting to fix one pixel difference error
Rinchan20 ac69c59
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 b8c63e5
Merge branch 'develop' into pepper-1251-playwright-place-an-order-in-…
Rinchan20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,16 +11,17 @@ export enum KitSampleType { | |
} | ||
|
||
export enum DataFilter { | ||
NOT_EMPTY = 'Not Empty', | ||
EXACT_MATCH = 'Exact Match', | ||
RANGE = 'Range', | ||
EMPTY = 'Empty', | ||
ENROLLED = 'Enrolled', | ||
REQUEST = 'Request', | ||
RECEIVED = 'Received', | ||
EXACT_MATCH = 'Exact Match', | ||
LOST_TO_FOLLOWUP = 'Lost to Followup', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just moved things into alphabetical order |
||
NO = 'No', | ||
YES = 'Yes', | ||
NOT_EMPTY = 'Not Empty', | ||
RANGE = 'Range', | ||
RECEIVED = 'Received', | ||
REGISTERED = 'Registered', | ||
REQUEST = 'Request', | ||
YES = 'Yes', | ||
} | ||
|
||
export enum FieldSettingInputType { | ||
|
@@ -787,3 +788,24 @@ export enum ParticipantListPageOptions { | |
SAVE_CURRENT_VIEW = 'Save Current View', | ||
SAVED_FILTERS = 'Saved Filters', | ||
} | ||
|
||
export enum SequencingOrderColumn { | ||
SAMPLE_TYPE = 'Sample Type', | ||
SAMPLE = 'Sample', | ||
SAMPLE_STATUS = 'Sample Status', | ||
COLLECTION_DATE = 'Collection Date', | ||
LATEST_SEQUENCING_ORDER_DATE = 'Latest Sequencing Order Date', | ||
LATEST_ORDER_STATUS = 'Latest Order Status', | ||
LATEST_ORDER_NUMBER = 'Latest Order Number', | ||
LATEST_PDO_NUMBER = 'Latest PDO Number', | ||
} | ||
|
||
export enum ClinicalOrdersColumn { | ||
SHORT_ID = 'Short ID', | ||
SAMPLE_TYPE = 'Sample Type', | ||
SAMPLE = 'Sample', | ||
ORDER_NUMBER = 'Order Number', | ||
ORDER_DATE = 'Order Date', | ||
STATUS = 'Status', | ||
STATUS_DETAIL = 'Status Detail' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we aren't dipping into pubsub for these tests. Do we need these values for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep - I use them in placeMercuryOrder():

I'm using the method shown here: https://cloud.google.com/pubsub/docs/publisher#node.js_1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you say a bit more about why we need to interact with pubsub directly when there's a "place order" button on the UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - the "place order" button usually just fills the Latest Sequencing Order Date column and the Latest Order Number column. I need to use pubsub in order to make sure that the Latest Order Status and Latest PDO Number are also filled out.

Below is state of the orders with just "place order" used (see the ones with "10/15/2024" as the Latest Sequencing Order Date):
Below is after using pubsub (Latest Order Status and Latest PDO Number are now filled out):

attaching the doc that has the testing steps since video reference is too big to attach: https://docs.google.com/document/d/1TGCnJGNz-HPYo1zO7wEeVHjkhm0NEgOEQHwyoCU12aI/edit?tab=t.0