Skip to content

create Anchor Screen Dashboard #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

rcreasi
Copy link
Contributor

@rcreasi rcreasi commented Apr 16, 2025

@rcreasi rcreasi requested a review from pgm April 16, 2025 20:36
Copy link
Contributor

@pgm pgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

My only question is about whether we want to continue the precedent of defining an legacy portal endpoint for each table.

But perhaps we can discuss in TPP?

@@ -574,3 +575,45 @@ def get_column_types():
return cols

return DataTableData(get_column_types, get_data)


def get_anchor_screen_metadata_table():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow. This is a lot more hassle then I was expecting you to have to go through.

I was imagining the react component could just fetch the data from breadbox. (I was actually just having a similar conversation with Jessica yesterday and advocated for bypassing the portal backend.)

I know this is historically how we've handled tables, but do you see advantages to keeping this pattern? It has always struck me as extra complicated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way WideTable works currently wants a static link to point to for the CSV download. I didn't want to mess with that because there's something nice about it being a proper resource. We have some code to transform JSON to CSV on the frontend but it's not particularly well-written. So I just stuck with the tried and truth method.

Comment on lines +19 to +33
<p>
Below is a table of the anchor screens which have data analyzed and
loaded into the portal. The “volcano” links will show a volcano plot
of the differential analysis produced by “Chronos compare.” The
“scatter” links will show a scatter plot of the drug arm vs the
control arm.
</p>
<p>
<b>Note</b>: the screens shown in the scatter plot are from
processing all screens together with Chronos, whereas the Chronos
compare volcano plots processed only the anchor screens. As a
result, the differential effect size in the volcano plot should be
similar but not exactly the same as the difference shown in the
scatter plot.
</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgm Copypasta taken from here.

rcreasi added 2 commits April 18, 2025 11:36
If it was set to a given_id and you tried to select a different
feature/sample, it would get confused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants