Change context matrix to subtype matrix #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgm
reviewed
Apr 17, 2025
| @@ -83,4 +83,4 @@ rule publish_context_matrix: | |||
| update_taiga_script=fileref('upload_to_taiga.py') | |||
| outputs:{"type": "release_context_matrix_published"} | |||
|
|
|||
| run "python3 {{inputs.update_taiga_script.filename}} {{inputs.release_taiga_id.dataset_id}} 'Created ContextMatrix for release' 'ContextMatrix' {{inputs.context_matrix.filename}} 'csv_matrix'" | |||
| run "python3 {{inputs.update_taiga_script.filename}} {{inputs.release_taiga_id.dataset_id}} 'Created ContextMatrix for release' 'SubtypeMatrix' {{inputs.context_matrix.filename}} 'csv_matrix'" | |||
There was a problem hiding this comment.
Should we call it "Subtype Matrix" in context manager as well?
(Currently it's being called "Context Matrix")
There was a problem hiding this comment.
Yes, that's the plan. I'm making that part of the renaming changes
pgm
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the name of ContextMatrix to be SubtypeMatrix in the release files so that it's more clear what is in this file, and so that it matches the name of SubtypeTree.
Also added special request for PedDep subtypes.