-
Notifications
You must be signed in to change notification settings - Fork 603
BQSR: restore ability to specify custom covariates and to disable standard covariates #4688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ndard covariates Added a quick-and-dirty temporary port of RepeatLengthCovariate to test this functionality. Resolves #4568
Not ready for merge yet! Needs tests + some additional fixes for @takutosato please try this branch out with your new homopolymer covariate and let me know whether it works! Feel free to grab some time on my calendar next week for help working through any issues. |
Codecov Report
@@ Coverage Diff @@
## master #4688 +/- ##
===============================================
+ Coverage 79.842% 79.857% +0.015%
- Complexity 17332 17497 +165
===============================================
Files 1074 1075 +1
Lines 62924 63442 +518
Branches 10182 10341 +159
===============================================
+ Hits 50240 50663 +423
- Misses 8704 8783 +79
- Partials 3980 3996 +16
|
@takutosato Have you had a chance to try this branch out with your new covariate yet? |
@droazen sorry I've been working on my other project but am hoping to spend some time on this on Friday! |
@takutosato Just checking in -- had a chance to try this branch out yet with your covariate? |
@droazen had to set this aside a little but I'm going to work on it today! |
@takutosato What's the status of this? Do you still need this feature? |
Added a quick-and-dirty temporary port of RepeatLengthCovariate
to test this functionality.
Resolves #4568