[JN-1644] virus scanning infrastructure #1547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorlbark
changed the title
MatthewBemis
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Nice. Just left one quick question.
I'll close out this PR too since it no longer brings anything to the table.
terraform/gcp/envs/dev.tfvars
Outdated
Comment on lines
12
to
14
| artifact_registry = "juniper" | ||
| artifact_registry_project = "broad-juniper-eng-infra" | ||
| artifact_registry_location = "us-central1" |
There was a problem hiding this comment.
do these need to be explicitly set here since they're the defaults in variables.tf?
There was a problem hiding this comment.
good point, they don't. I'll remove them when I apply to prod.
devonbush
approved these changes
Mar 25, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
Originally, I thought it would be best to run this code in Eng infra. After some reflection (and it proving to be more difficult than I thought), I realized it might be better to keep prod/dev virus scanning separate.
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)