Skip to content

[JN-1651] previous responses read only #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Mar 31, 2025
Merged

[JN-1651] previous responses read only #1552

merged 21 commits into from
Mar 31, 2025

Conversation

connorlbark
Copy link
Collaborator

@connorlbark connorlbark commented Mar 21, 2025 •
edited
Loading

DESCRIPTION (include screenshots, and mobile screenshots for participant UX)

Cleans up admin experience as well.

TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)

  • Log in as jsalk
  • Check out previous lifestyle surveys
  • Go to latest
  • Update it; ensure it saves as new row
  • Go to admin tool
  • Update jsalk's previous responses
  • Ensure that it doesn't trigger the same mechanisms for admins (updates in-place always, can update previous responses)

@connorlbark connorlbark changed the base branch from development to mb-jn-1619-v2 March 21, 2025 14:56
@connorlbark connorlbark marked this pull request as ready for review March 21, 2025 15:02
devonbush
devonbush requested changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@devonbush devonbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we need to still let admins edit prior survey responses.

@connorlbark
Copy link
Collaborator Author

Looks good, but I think we need to still let admins edit prior survey responses.

great catch

Base automatically changed from mb-jn-1619-v2 to development March 28, 2025 14:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@connorlbark connorlbark requested a review from devonbush March 28, 2025 17:45
devonbush
devonbush approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@devonbush devonbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@connorlbark connorlbark merged commit 1e6d01e into development Mar 31, 2025
18 checks passed
@connorlbark connorlbark deleted the cb-previous-responses-read-only branch March 31, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devonbush devonbush devonbush approved these changes

@MatthewBemis MatthewBemis MatthewBemis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorlbark @devonbush @MatthewBemis