Skip to content

[JN-1653] display/handle virus scan results #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 31, 2025

Conversation

connorlbark
Copy link
Collaborator

@connorlbark connorlbark commented Mar 21, 2025

DESCRIPTION (include screenshots, and mobile screenshots for participant UX)

Not the fanciest UI but it works - will add i18n before merging.

Screenshot 2025-03-24 at 2 17 52 PM Screenshot 2025-03-24 at 2 19 42 PM Screenshot 2025-03-24 at 2 22 14 PM

TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)

  • Replace LocalFileStorageBackend with GCSFileStorageBackend in application.yml for admin and participant
  • We can simulate an in-progress scan with an empty file (as empty files will not be picked up by the virus scanner)
touch emptyfile.txt
  • Upload emptyfile.txt - you'll get an error related to it being empty, I don't think this will ever happen, so I haven't investigated this muhc
  • Observe it's stuck in in-progress - look in admin view and attempt to download as participant
  • You can simulate a quarantined file by manually moving the into the quarantined bucket
  • Superusers can now see the external file ID in the document requests page (not visible to regular users)
  • Move it over:
gsutil mv gs://juniper-participant-documents-dev-clean/<id> gs://juniper-participant-documents-dev-quarantined/<id>
  • Observe how admin/participant UIs handle quarantined files

@connorlbark connorlbark changed the title [JN-1653] display/handle virus scan results [JN-1653] WIP display/handle virus scan results Mar 21, 2025
@connorlbark connorlbark changed the title [JN-1653] WIP display/handle virus scan results [JN-1653] display/handle virus scan results Mar 24, 2025
@connorlbark connorlbark marked this pull request as ready for review March 24, 2025 19:26
@connorlbark connorlbark merged commit 80540ed into development Mar 31, 2025
17 checks passed
@connorlbark connorlbark deleted the cb-handle-virus-scan-results-in-ui branch March 31, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants