ID-1270 create_with_parent Action #1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghost-in-a-Jar
approved these changes
May 22, 2024
samanehsan
reviewed
May 23, 2024
| @@ -75,7 +75,9 @@ trait SecurityDirectives { | |||
| case None => Directives.pass // no parent specified, proceed | |||
| case Some(parent) => | |||
| // parents are allowed for a resource type if the owner role contains the SamResourceActions.setParent action | |||
There was a problem hiding this comment.
Could you update this comment too?
samanehsan
approved these changes
May 23, 2024
|
Is there anyone creating parent resources right now that needs to know about this change? |
|
@samanehsan This unblocks other people to be able to make/edit resources with the correct role actions. We're just providing the capability. I've already pinged Data Exploration to let them know this is being done. |
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-1270
<Don't forget to include the ticket number in the PR title!>
What:
Introduce a
create_with_parentresource action, which will allow resource creation with a parent resource without letting users re-parent the resource later.Why:
Needed for future functionality.
How:
Just add the resource action.
PR checklist