Skip to content

Release 1.97.0#2269

Merged
bistline merged 25 commits intomainfrom
development
Jun 4, 2025
Merged

Release 1.97.0#2269
bistline merged 25 commits intomainfrom
development

Conversation

@bistline
Copy link
Copy Markdown
Contributor

@bistline bistline commented Jun 3, 2025

No description provided.

bistline added 23 commits May 20, 2025 13:38
…upload

Strip undefined attributes during StudyFile creation (SCP-5996)
Adding study-creation and study-state Mixpanel events
# Conflicts:
#	app/controllers/api/v1/study_files_controller.rb
Configuring study defaults with relevant biological annotations (SCP-6014)
@bistline bistline requested a review from eweitz June 3, 2025 20:35
Copy link
Copy Markdown
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failure is a false positive, because it's from #2266 that was marked as such. (I also reviewed the original error and agree it's a false positive.)

Summary:

Total elapsed time: 25 minutes, 43 seconds

### FAILURES and ERRORS ###
*** Yarn test failures ***

*** Rails test failures ***

  StudyValidationTest#before_all:
  Mongoid::Errors::Validations: 
Exiting with code: 1
Error: Process completed with exit code 1.

Details:

Finished in 1314.870259s, 0.5377 runs/s, 2.2466 assertions/s.

  1) Error:
StudyValidationTest#before_all:
Mongoid::Errors::Validations: 
message:
  Validation of Study failed.
summary:
  The following errors were found: Firecloud workspace  creation failed: Internal server exception [sentryId=5559807ab3a746e6b6b9f8dbb6e8684a]
resolution:
  Try persisting the document with valid data or remove the validations.
    test/integration/external/study_validation_test.rb:18:in 'block in <class:StudyValidationTest>'
    test/test_helper.rb:39:in 'block (2 levels) in <module:TestInstrumentor>'
    test/test_helper.rb:39:in 'block in <module:TestInstrumentor>'

707 runs, 2954 assertions, 0 failures, 1 errors, 11 skips

@bistline bistline added the build failure: false positive Build error confirmed as false positive. E.g. upstream service has a problem. label Jun 4, 2025
@bistline bistline merged commit 68225af into main Jun 4, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build failure: false positive Build error confirmed as false positive. E.g. upstream service has a problem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants