Merged
Conversation
eweitz
approved these changes
Jun 3, 2025
Member
eweitz
left a comment
There was a problem hiding this comment.
The build failure is a false positive, because it's from #2266 that was marked as such. (I also reviewed the original error and agree it's a false positive.)
Summary:
Total elapsed time: 25 minutes, 43 seconds
### FAILURES and ERRORS ###
*** Yarn test failures ***
*** Rails test failures ***
StudyValidationTest#before_all:
Mongoid::Errors::Validations:
Exiting with code: 1
Error: Process completed with exit code 1.
Details:
Finished in 1314.870259s, 0.5377 runs/s, 2.2466 assertions/s.
1) Error:
StudyValidationTest#before_all:
Mongoid::Errors::Validations:
message:
Validation of Study failed.
summary:
The following errors were found: Firecloud workspace creation failed: Internal server exception [sentryId=5559807ab3a746e6b6b9f8dbb6e8684a]
resolution:
Try persisting the document with valid data or remove the validations.
test/integration/external/study_validation_test.rb:18:in 'block in <class:StudyValidationTest>'
test/test_helper.rb:39:in 'block (2 levels) in <module:TestInstrumentor>'
test/test_helper.rb:39:in 'block in <module:TestInstrumentor>'
707 runs, 2954 assertions, 0 failures, 1 errors, 11 skips
Prevent errors when assembling ingestSummary properties (SCP-6015)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.