Skip to content

Integration of taxonomic classifier trainer wdl #459

Open
golu099 wants to merge 14 commits intomasterfrom
fn_training_classifier_2
Open

Integration of taxonomic classifier trainer wdl #459
golu099 wants to merge 14 commits intomasterfrom
fn_training_classifier_2

Conversation

@golu099
Copy link
Copy Markdown
Contributor

@golu099 golu099 commented Mar 24, 2023

Description of WDL: User imports OTU sequences and taxonomy from desired rRNA database for classifier training on target region.

Copy link
Copy Markdown
Member

@dpark01 dpark01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just some small things

dpark01 and others added 5 commits April 13, 2023 13:35
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
@golu099
Copy link
Copy Markdown
Contributor Author

golu099 commented May 2, 2023

I think this PR is good to go, from what i see now more comment/edits were made for this PR.

@dpark01
Copy link
Copy Markdown
Member

dpark01 commented May 2, 2023

This is great, I think the only things left are:

  1. git rm pipes/WDL/workflows/16S_train_classifier.wdl from this branch (see image below, you've still got a vestigal file in this PR)
  2. update the branch to the latest master

image

@dpark01
Copy link
Copy Markdown
Member

dpark01 commented Mar 19, 2024

This PR looks a bit stale -- let's figure out where we left it off and sort it out one way or the other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants