remove 15 min timeout from poll_job_status#1519
Merged
mmorgantaylor merged 2 commits intodevelopfrom Feb 27, 2025
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
nikellepetrillo
approved these changes
Feb 27, 2025
ekiernan
approved these changes
Feb 27, 2025
jessicaway
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The poll_job_status() function had a 15 minute timeout that was causing tests to pass after 15 minutes no matter whether the actual workflow succeeded or failed in Terra.
Here we remove this 15 minute timeout in the poll_job_status() function to allow workflows to proceed indefinitely until they complete.
Checklist
If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.