Skip to content

remove 15 min timeout from poll_job_status#1519

Merged
mmorgantaylor merged 2 commits intodevelopfrom
mma_remove_timeout_from_poll_job_status
Feb 27, 2025
Merged

remove 15 min timeout from poll_job_status#1519
mmorgantaylor merged 2 commits intodevelopfrom
mma_remove_timeout_from_poll_job_status

Conversation

@mmorgantaylor
Copy link
Copy Markdown
Member

@mmorgantaylor mmorgantaylor commented Feb 27, 2025

Description

The poll_job_status() function had a 15 minute timeout that was causing tests to pass after 15 minutes no matter whether the actual workflow succeeded or failed in Terra.

Here we remove this 15 minute timeout in the poll_job_status() function to allow workflows to proceed indefinitely until they complete.


Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

@dsde-jenkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@github-actions
Copy link
Copy Markdown

Remember to squash merge!

@github-actions
Copy link
Copy Markdown

🔍Changelog Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions
Copy link
Copy Markdown

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions
Copy link
Copy Markdown

Remember to squash merge!

@github-actions
Copy link
Copy Markdown

🔍Changelog Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions
Copy link
Copy Markdown

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@mmorgantaylor mmorgantaylor merged commit 62b78c3 into develop Feb 27, 2025
30 checks passed
@mmorgantaylor mmorgantaylor deleted the mma_remove_timeout_from_poll_job_status branch September 23, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants