TSPS-789 lower allowable nubmer of variants qc check to 3 #1762
Merged
jsotobroad merged 4 commits intodevelopfrom Feb 5, 2026
Merged
TSPS-789 lower allowable nubmer of variants qc check to 3 #1762jsotobroad merged 4 commits intodevelopfrom
jsotobroad merged 4 commits intodevelopfrom
Conversation
…lion in array imputation qc wdl
|
Remember to squash merge! |
🔍Version Validation Results: |
🔍Changelog Validation Results: |
|
Remember to squash merge! |
🔍Version Validation Results: |
🔍Changelog Validation Results: |
mmorgantaylor
approved these changes
Feb 4, 2026
| # 2.5.1 | ||
| 2026-2-04 (Date of Last Commit) | ||
|
|
||
| * Update input_qc_version to 1.2.5 to match the latest changes in InputQC wdl. |
Member
There was a problem hiding this comment.
Suggested change
| * Update input_qc_version to 1.2.5 to match the latest changes in InputQC wdl. | |
| * Update input_qc_version to 1.3.0 to match the latest changes in InputQC wdl. |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
salonishah11
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We've noticed some submissions of WGS data to teaspoons' array imputation pipeline with just under 10 milliion variant sites. We dont want to allow that so are going to be stricter with the number of variants we allow. This should not affect actual array inputs.
https://broadworkbench.atlassian.net/browse/TSPS-789
Expected failure from the qc tests - https://app.terra.bio/#workspaces/warp-pipelines/WARP%20Tests/submission_history/2bd9ffba-29ee-4994-ac15-68b19802b759
We now log the number of variants in the input vcf for passing files. can be seen in https://app.terra.bio/#workspaces/warp-pipelines/WARP%20Tests/submission_history/67ff5012-8057-4537-81e8-a6f2b567a37c
Checklist
If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.