Skip to content

TSPS-789 lower allowable nubmer of variants qc check to 3 #1762

Merged
jsotobroad merged 4 commits intodevelopfrom
js_TSPS-797
Feb 5, 2026
Merged

TSPS-789 lower allowable nubmer of variants qc check to 3 #1762
jsotobroad merged 4 commits intodevelopfrom
js_TSPS-797

Conversation

@jsotobroad
Copy link
Copy Markdown
Contributor

@jsotobroad jsotobroad commented Feb 4, 2026

Description

We've noticed some submissions of WGS data to teaspoons' array imputation pipeline with just under 10 milliion variant sites. We dont want to allow that so are going to be stricter with the number of variants we allow. This should not affect actual array inputs.

https://broadworkbench.atlassian.net/browse/TSPS-789

Expected failure from the qc tests - https://app.terra.bio/#workspaces/warp-pipelines/WARP%20Tests/submission_history/2bd9ffba-29ee-4994-ac15-68b19802b759

2026-02-04 13:37:00.327 EST
< qc_messages Greater than 3 million variants found in the input VCF.
2026-02-04 13:37:00.327 EST
---
2026-02-04 13:37:00.327 EST
> qc_messages Greater than 10 million variants found in the input VCF.

We now log the number of variants in the input vcf for passing files. can be seen in https://app.terra.bio/#workspaces/warp-pipelines/WARP%20Tests/submission_history/67ff5012-8057-4537-81e8-a6f2b567a37c

2026-02-04 13:26:57.696 EST
1900151 variants found in input VCF.

Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

Remember to squash merge!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

Remember to squash merge!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

# 2.5.1
2026-2-04 (Date of Last Commit)

* Update input_qc_version to 1.2.5 to match the latest changes in InputQC wdl.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Update input_qc_version to 1.2.5 to match the latest changes in InputQC wdl.
* Update input_qc_version to 1.3.0 to match the latest changes in InputQC wdl.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

Remember to squash merge!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@jsotobroad jsotobroad changed the title TSPS-797 lower allowable nubmer of variants qc check to 3 TSPS-789 lower allowable nubmer of variants qc check to 3 Feb 4, 2026
@jsotobroad jsotobroad merged commit 11aa131 into develop Feb 5, 2026
11 of 12 checks passed
@jsotobroad jsotobroad deleted the js_TSPS-797 branch February 5, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants