fix: support media query for color schemes#2361
Open
twio142 wants to merge 1 commit into
Open
Conversation
also prevents the canvas' white background when color scheme is dark
Owner
hbt
added a commit
to hbt/Surfingkeys
that referenced
this pull request
May 30, 2026
Fixes white background flash in the SK UI iframe when OS/browser is in dark mode. uiHost.style.colorScheme was hardcoded to "light", forcing the browser to render the iframe with light-mode default backgrounds even when user theme CSS uses @media (prefers-color-scheme: dark). Refs upstream PR brookhong#2361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables
@media (prefers-color-scheme: dark)insettings.theme.When
uiHost.style.colorSchemeis undefined, or set to "normal", the iframe can also follow the system theme but shows an white background when switching to dark mode. Setting it to "auto" avoids this issue.