Skip to content

chore: add missing dependencies for run jest#2419

Open
Omochice wants to merge 1 commit into
brookhong:masterfrom
Omochice:add-missing-jest-deps
Open

chore: add missing dependencies for run jest#2419
Omochice wants to merge 1 commit into
brookhong:masterfrom
Omochice:add-missing-jest-deps

Conversation

@Omochice

Copy link
Copy Markdown

Summary

Add @babel/runtime required to run jest.

Details

I tried building it locally, but it was missing dependencies and we couldn't run the test.

In CI, tests cannot be executed due to the same reason, so we will fix this.

(By the way, why is there no package-lock.json? I'll add it in a separate PR if necessary.)

Confirmation

  • Being able to run npm run test locally
    • However, the test itself seems to fail
  • Tests can be executed with CI

Limitation

Only development dependency, no impact on userland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant