Open
Conversation
Member
grkvlt
commented
Sep 10, 2016
grkvlt
commented
- Only changes entities in same application
- Uses AttributeSensor config type for coercion
- Standardisd YAML formatting on all files
- Configure entity filter and optional host file overwrite
ahgittin
approved these changes
Sep 15, 2016
Member
ahgittin
left a comment
ahgittin
left a comment
There was a problem hiding this comment.
Looks reasonable. I'd rather a brooklyn "scope" (this app v all apps) field in Group rather than adding the predicate but it can be changed later (with default being all apps now, but deprecated and warning so we can change it later). I'd also like to have the QA framework running against this so we have confidence it works.
But if you've tested I'm happy to have this merged.
Member
Author
|
@ahgittin still needs a bit of testing, so not yet ready to merge |
- Only changes entities in same application - Uses AttributeSensor config type for coercion - Standardisd YAML formatting on all files - Configure entity filter and optional host file overwrite
grkvlt
force-pushed
the
config-and-formatting
branch
from
33117fa to
abde8d9
Compare
grkvlt
force-pushed
the
config-and-formatting
branch
from
abde8d9 to
83261dd
Compare
tbouron
force-pushed
the
master
branch
4 times, most recently
from
24b9b56 to
a968595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.