Updated browscap-php to support symfony/console:7.4+ - #822
Merged
Conversation
Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](dependabot/fetch-metadata@v3.0.0...v3.1.0) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-version: 3.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ns/dependabot/fetch-metadata-3.1.0 github-actions: bump dependabot/fetch-metadata from 3.0.0 to 3.1.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 7.8.x #822 +/- ##
========================================
Coverage ? 36.74%
Complexity ? 283
========================================
Files ? 27
Lines ? 1132
Branches ? 0
========================================
Hits ? 416
Misses ? 716
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asgrim
approved these changes
Apr 21, 2026
Member
|
Thanks! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Symfony 7.4,
Application::addhas been renamedApplication::addCommand. If you're using browscap-php in an existing project that uses Symfony and you require a version ofsymfony/consolewith the new syntax then calls tobin/browscap-phpwill fail with:To add support for the newer syntax while not breaking backwards compatibility I check the version of
symfony/consoleinstalled and use the old or new syntax ass appropriate.I'll note as well that this wasn't picked up when running tests - I only ran
phpunitso unless there are other ways to test I think this file isn't covered, so that's probably why it wasn't picked up earlier.Haven't made many PRs in my life so apologies if I've made a booboo somewhere.