Skip to content

Modify to use override page fixture instead of override browser #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

Modify to use override page fixture instead of override browser #15

merged 1 commit into from
Jan 11, 2022

Conversation

karanshah-browserstack
Copy link
Collaborator

Modify to use override page fixture instead of override browser and change tests title

sourav-kundu
sourav-kundu approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@sourav-kundu sourav-kundu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francisf francisf merged commit 5d04ea0 into browserstack:main Jan 11, 2022
@karanshah-browserstack karanshah-browserstack deleted the override_page_fixture branch January 11, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francisf francisf francisf approved these changes

@SaranshBS SaranshBS SaranshBS approved these changes

@sourav-kundu sourav-kundu sourav-kundu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karanshah-browserstack @francisf @SaranshBS @sourav-kundu