added get session details sample scripts #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asambstack
reviewed
Mar 15, 2022
asambstack
previously approved these changes
Mar 15, 2022
karanshah-browserstack
requested changes
Mar 16, 2022
| catch (Exception err) { | ||
| await MarkTestStatus("failed", err.Message, page); | ||
| } | ||
| Object sessionObject = await page.EvaluateAsync("_ => {}", "browserstack_executor: {\"action\":\"getSessionDetails\"}"); |
There was a problem hiding this comment.
This will come after else block. If page is destroyed and comes in catch block and post which we try to getSessionDetails it will throw error.
| Browser browser = chromium.connect(ws_endpoint); | ||
| BrowserContext context = browser.newContext(new Browser.NewContextOptions() | ||
| .setUserAgent("Mozilla/5.0 (Linux; Android 11; Pixel 5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/101.0.4943.0 Mobile Safari/537.36") | ||
| .setViewportSize(393, 727) |
There was a problem hiding this comment.
Can we fetch this viewport from devices json based on device name?
| mark_test_status("failed", str(err), page) | ||
|
|
||
| # get details of the session | ||
| response = page.evaluate("_=> {}", 'browserstack_executor: {"action": "getSessionDetails"}') |
There was a problem hiding this comment.
This should be before except block
francisf
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.