Skip to content

refactor(core): centralize blockchain_rpc methods into a single enum #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xdeafbeef
Copy link
Member

Reduce boilerplate for metrics.
Split rpc on several files.

@0xdeafbeef 0xdeafbeef requested review from pashinov and Rexagon April 7, 2025 15:20
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 69.73684% with 23 lines in your changes missing coverage. Please review.

Project coverage is 45.22%. Comparing base (313a8ed) to head (d9253aa).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
core/src/blockchain_rpc/service/mod.rs 67.56% 12 Missing ⚠️
util/src/metrics/histogram_guard.rs 70.00% 8 Missing and 1 partial ⚠️
core/src/blockchain_rpc/service/util.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   45.14%   45.22%   +0.08%     
==========================================
  Files         291      292       +1     
  Lines       55030    55046      +16     
  Branches    55030    55046      +16     
==========================================
+ Hits        24842    24897      +55     
+ Misses      28946    28913      -33     
+ Partials     1242     1236       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xdeafbeef 0xdeafbeef added this to the 050 Other milestone May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants