[TC-5] review-checklist: cohesion (hl/ + HDF5Examples/)#9
Open
brtnfld wants to merge 2 commits into
Open
Conversation
…esting Temporary commit to test the review-checklist action on the fork. Revert develop to this point after testing is complete.
Review ChecklistThis PR touches the following areas. Each needs at least one
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test case TC-5 — two areas with overlapping owner lists. Tests the cohesion logic: once a reviewer is picked for the first area, they are reused for subsequent areas where they appear in the owner list, rather than issuing a second independent load-balanced pick.
Touched areas:
hl/— owned by@brtnfld @mattjalaHDF5Examples/— owned by@brtnfld @jhendersonHDFExpected behaviour:
hl,HDF5Examplesbrtnfldassigned as PR assignee (author is a code owner)hl/: author (brtnfld) filtered out →mattjalapicked (load-balanced)HDF5Examples/:brtnfldfiltered out;mattjalais NOT in its owner list → no cohesion reuse;jhendersonHDFpicked (load-balanced)Safe to close and delete branch after review.