-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better \kern in svg #2533
Better \kern in svg #2533
Conversation
Since reviewing |
…ut, make \hbox close to the appropriate svg:g; And make auto opened svg:g able to auto close
6904e01
to
969fbd9
Compare
It should show up in the |
The reason we have them in the "extra" tests is that we can't reproduce the exact same XML markup across texlives (as the internal Edit: Ah, but that was true of pgf, not xy, fair. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, |
Currently a
\kern
in svg adds the shift to the containingsvg:g
, but if there already were children, they get shifted as well. We really want to create a newsvg:g
in that case. Alas, there was clumsiness in other places dealing withsvg:g
, namely\hbox
would wrap it's content insvg:g
, but didn't actually close the correct container when done, so that got simplified as well. And finally, a fewsvg:g
that got created by the driver, behind the scenes, needed to be marked asautoclose
, so that they could be properly closed.Thanks, @xworld21 for the excellent debugging, but I think this ends up being simpler, in the long run, than #2502.
check if this does what you expect.
Closes #2502