add viewBox in xy, with baseline adjustment #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xworld21
reviewed
Mar 21, 2025
| @@ -191,7 +191,7 @@ a.ltx_LaTeXML_logo { text-decoration: none; } | |||
|
|
|||
| .ltx_tabular .ltx_tabular { width:100%; } | |||
| .ltx_inline-block, | |||
| .ltx_inline-logical-block { display:inline-block; } | |||
| .ltx_inline-logical-block { display:inline-block; text-indent:0px; } | |||
There was a problem hiding this comment.
Right, I have seen text-indent getting inherited and cause issues! This will have some side effects, but all good I hope. It's just a bit weird to see it in a xypic PR.
There was a problem hiding this comment.
Indeed, but not as weird as the effect it caused on a test case! :>
This was referenced Mar 22, 2025
Merged
dginev
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds viewbox to XY's svg along with baseline adjustment (via
vertical-align). It also wraps the svg in an inline-block so that the baseline works even when withinmtext(even in Firefox). We also add a couple of interesting test cases to the xy tests.This is an alternative to #2397 and steals most of the code, but deals with the baseline adjustment differently. Thanks @xworld21 for excellent debugging and useful testcase!!!
Closes #2397
Fixes #2376